Skip to content

Update PostgreSQL JDBC driver#12025

Merged
hashhar merged 1 commit intotrinodb:masterfrom
hashhar:hashhar/pgjdbc-update
Apr 20, 2022
Merged

Update PostgreSQL JDBC driver#12025
hashhar merged 1 commit intotrinodb:masterfrom
hashhar:hashhar/pgjdbc-update

Conversation

@hashhar
Copy link
Copy Markdown
Member

@hashhar hashhar commented Apr 19, 2022

These are no functional changes so no release notes. Just maintenance work.

@hashhar hashhar added maintenance Project maintenance task no-release-notes This pull request does not require release notes entry labels Apr 19, 2022
@hashhar hashhar requested a review from ebyhr April 19, 2022 17:11
@cla-bot cla-bot bot added the cla-signed label Apr 19, 2022
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I tested, pgjdbc/pgjdbc#2221 fixes ResultSet.getString workaround on date type. Could you fix the type mapping in PostgreSqlClient like this?

            case Types.DATE:
                return Optional.of(dateColumnMappingUsingLocalDate());

@hashhar hashhar force-pushed the hashhar/pgjdbc-update branch from 7c8ce29 to 2681737 Compare April 20, 2022 05:59
This allows using the standard LocalDate mapping for DATE columns
instead of parsing the string using a DateTimeFormatter.
@hashhar hashhar force-pushed the hashhar/pgjdbc-update branch from 2681737 to 224e639 Compare April 20, 2022 06:33
@hashhar hashhar merged commit b0dbd3a into trinodb:master Apr 20, 2022
@hashhar hashhar deleted the hashhar/pgjdbc-update branch April 20, 2022 09:18
@github-actions github-actions bot added this to the 378 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants