Remove obsolete TODO in getIcebergLiteralValue#12023
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 21, 2022
Merged
Conversation
When the code section was added, the method handled selected types and had implicit fallback. Nowdays, the method must support all types explicitly, and there is no follback behavior.
findepi
added
the
no-release-notes
alexjo2144
approved these changes
Apr 19, 2022
ebyhr
approved these changes
Apr 19, 2022
Member
Author
|
@Praveen2112 did I read the TODO's intention correctly? |
Member
Author
|
Assuming I did. |
findepi
deleted the
findepi/remove-obsolete-todo-in-geticebergliteralvalue-c3cc01
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the code section was added, the method handled selected types and
had implicit fallback. Nowdays, the method must support all types
explicitly, and there is no follback behavior.