Skip to content

Add impersonation to related metastore calls #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 1 commit into from
Apr 20, 2022
Merged

Add impersonation to related metastore calls #12002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions ...trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/BridgingHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ public BridgingHiveMetastore(ThriftMetastore delegate, HiveIdentity identity)
@Override
public Optional<Database> getDatabase(String databaseName)
{
return delegate.getDatabase(databaseName).map(ThriftMetastoreUtil::fromMetastoreApiDatabase);
return delegate.getDatabase(identity, databaseName).map(ThriftMetastoreUtil::fromMetastoreApiDatabase);
}

@Override
public List<String> getAllDatabases()
{
return delegate.getAllDatabases();
return delegate.getAllDatabases(identity);
}

@Override
Expand Down Expand Up @@ -143,19 +143,19 @@ public void updatePartitionStatistics(Table table, Map<String, Function<Partitio
@Override
public List<String> getAllTables(String databaseName)
{
return delegate.getAllTables(databaseName);
return delegate.getAllTables(identity, databaseName);
}

@Override
public List<String> getTablesWithParameter(String databaseName, String parameterKey, String parameterValue)
{
return delegate.getTablesWithParameter(databaseName, parameterKey, parameterValue);
return delegate.getTablesWithParameter(identity, databaseName, parameterKey, parameterValue);
}

@Override
public List<String> getAllViews(String databaseName)
{
return delegate.getAllViews(databaseName);
return delegate.getAllViews(identity, databaseName);
}

@Override
Expand All @@ -173,12 +173,12 @@ public void dropDatabase(String databaseName, boolean deleteData)
@Override
public void renameDatabase(String databaseName, String newDatabaseName)
{
org.apache.hadoop.hive.metastore.api.Database database = delegate.getDatabase(databaseName)
org.apache.hadoop.hive.metastore.api.Database database = delegate.getDatabase(identity, databaseName)
.orElseThrow(() -> new SchemaNotFoundException(databaseName));
database.setName(newDatabaseName);
delegate.alterDatabase(identity, databaseName, database);

delegate.getDatabase(databaseName).ifPresent(newDatabase -> {
delegate.getDatabase(identity, databaseName).ifPresent(newDatabase -> {
if (newDatabase.getName().equals(databaseName)) {
throw new TrinoException(NOT_SUPPORTED, "Hive metastore does not support renaming schemas");
}
Expand All @@ -188,7 +188,7 @@ public void renameDatabase(String databaseName, String newDatabaseName)
@Override
public void setDatabaseOwner(String databaseName, HivePrincipal principal)
{
Database database = fromMetastoreApiDatabase(delegate.getDatabase(databaseName)
Database database = fromMetastoreApiDatabase(delegate.getDatabase(identity, databaseName)
.orElseThrow(() -> new SchemaNotFoundException(databaseName)));

Database newDatabase = Database.builder(database)
Expand Down Expand Up @@ -408,67 +408,67 @@ public void alterPartition(String databaseName, String tableName, PartitionWithS
@Override
public void createRole(String role, String grantor)
{
delegate.createRole(role, grantor);
delegate.createRole(identity, role, grantor);
}

@Override
public void dropRole(String role)
{
delegate.dropRole(role);
delegate.dropRole(identity, role);
}

@Override
public Set<String> listRoles()
{
return delegate.listRoles();
return delegate.listRoles(identity);
}

@Override
public void grantRoles(Set<String> roles, Set<HivePrincipal> grantees, boolean adminOption, HivePrincipal grantor)
{
delegate.grantRoles(roles, grantees, adminOption, grantor);
delegate.grantRoles(identity, roles, grantees, adminOption, grantor);
}

@Override
public void revokeRoles(Set<String> roles, Set<HivePrincipal> grantees, boolean adminOption, HivePrincipal grantor)
{
delegate.revokeRoles(roles, grantees, adminOption, grantor);
delegate.revokeRoles(identity, roles, grantees, adminOption, grantor);
}

@Override
public Set<RoleGrant> listGrantedPrincipals(String role)
{
return delegate.listGrantedPrincipals(role);
return delegate.listGrantedPrincipals(identity, role);
}

@Override
public Set<RoleGrant> listRoleGrants(HivePrincipal principal)
{
return delegate.listRoleGrants(principal);
return delegate.listRoleGrants(identity, principal);
}

@Override
public void grantTablePrivileges(String databaseName, String tableName, String tableOwner, HivePrincipal grantee, HivePrincipal grantor, Set<HivePrivilege> privileges, boolean grantOption)
{
delegate.grantTablePrivileges(databaseName, tableName, tableOwner, grantee, grantor, privileges, grantOption);
delegate.grantTablePrivileges(identity, databaseName, tableName, tableOwner, grantee, grantor, privileges, grantOption);
}

@Override
public void revokeTablePrivileges(String databaseName, String tableName, String tableOwner, HivePrincipal grantee, HivePrincipal grantor, Set<HivePrivilege> privileges, boolean grantOption)
{
delegate.revokeTablePrivileges(databaseName, tableName, tableOwner, grantee, grantor, privileges, grantOption);
delegate.revokeTablePrivileges(identity, databaseName, tableName, tableOwner, grantee, grantor, privileges, grantOption);
}

@Override
public Set<HivePrivilegeInfo> listTablePrivileges(String databaseName, String tableName, Optional<String> tableOwner, Optional<HivePrincipal> principal)
{
return delegate.listTablePrivileges(databaseName, tableName, tableOwner, principal);
return delegate.listTablePrivileges(identity, databaseName, tableName, tableOwner, principal);
}

@Override
public Optional<String> getConfigValue(String name)
{
return delegate.getConfigValue(name);
return delegate.getConfigValue(identity, name);
}

@Override
Expand Down
Loading