Adjust connection pool parameters for S3 based exchange#11996
Merged
arhimondr merged 2 commits intotrinodb:masterfrom Apr 19, 2022
Merged
Adjust connection pool parameters for S3 based exchange#11996arhimondr merged 2 commits intotrinodb:masterfrom
arhimondr merged 2 commits intotrinodb:masterfrom
Conversation
linzebing
approved these changes
Apr 18, 2022
Member
|
CI: #11876 |
losipiuk
approved these changes
Apr 19, 2022
mosabua
reviewed
Apr 19, 2022
| return asyncClientMaxPendingConnectionAcquires; | ||
| } | ||
|
|
||
| @Config("exchange.s3.async-client-max-pending-connection-acquires") |
Member
There was a problem hiding this comment.
@arhimondr @losipiuk .. did we not want to document this property?
Contributor
Author
There was a problem hiding this comment.
It's pretty low level and it should generally not be changed. Not sure if it makes sense to document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce maximum number of concurrent requests and increase timeout for obtaining a connection from a pool.
Generally only ~15 connections should be enough to utilize 10Gbit / s NIC in one direction. 100 connections should be more than necessary. Allowing to many connections is likely to create unnecessary contention.
Improvement
Exchange
-Related issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: