Skip to content

Add ABFS product test for sync_partition_metadata#11992

Merged
ebyhr merged 2 commits intomasterfrom
ebi/abfs-test
May 6, 2022
Merged

Add ABFS product test for sync_partition_metadata#11992
ebyhr merged 2 commits intomasterfrom
ebi/abfs-test

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Apr 18, 2022

Description

Add ABFS product test for sync_partition_metadata procedure.

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Apr 18, 2022
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Apr 18, 2022
@ebyhr ebyhr force-pushed the ebi/abfs-test branch 18 times, most recently from ee193c5 to b40df13 Compare April 21, 2022 07:53
@ebyhr ebyhr force-pushed the ebi/abfs-test branch 8 times, most recently from 69374b4 to e4fc28f Compare April 26, 2022 13:25
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 28, 2022

All failures are related to #12147

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Apr 28, 2022

@findepi @nineinchnick Updated. Sorry for my dirty forced pushed diff.

@ebyhr ebyhr force-pushed the ebi/abfs-test branch from 49f437a to b9b137c Compare May 2, 2022 02:51
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented May 2, 2022

CI hit #12151

@ebyhr ebyhr requested a review from findepi May 2, 2022 07:59
@findepi
Copy link
Copy Markdown
Member

findepi commented May 5, 2022

(squashed and rebased, the build was almost green previously: https://github.com/trinodb/trino/runs/6252434621)

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebyhr added 2 commits May 6, 2022 10:32
This makes running the test on ABFS easily. Also,
rename the class name.
@ebyhr ebyhr force-pushed the ebi/abfs-test branch from 7514279 to b6dea49 Compare May 6, 2022 01:34
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented May 6, 2022

@ebyhr ebyhr requested a review from findepi May 6, 2022 06:45
@ebyhr ebyhr merged commit 5e47601 into master May 6, 2022
@ebyhr ebyhr deleted the ebi/abfs-test branch May 6, 2022 09:53
@github-actions github-actions bot added this to the 380 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants