Rename big_query group to large_query in product tests#11988
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Apr 18, 2022
Merged
Rename big_query group to large_query in product tests#11988ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
To avoid conflict with BigQuery connector.
hashhar
approved these changes
Apr 18, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
Can you also remove experimental_big_query from core/trino-main/src/test/resources/queue_config.json? That session property was removed in 0.109.
Member
Author
|
The json file seems unused at glance. Let me investigate and send a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
big_querygroup tolarge_queryin product tests. The previous name is confusing because we have BigQuery connector now.Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.