Merged
Conversation
pettyjamesm
force-pushed
the
improve-pages-index
branch
from
4c94a5a to
c4e7238
Compare
pettyjamesm
force-pushed
the
improve-pages-index
branch
from
c4e7238 to
ba938db
Compare
raunaqmorarka
approved these changes
Apr 20, 2022
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Change looks ok to me.
Is there any measurable impact of this in some JMH benchmark like BenchmarkPagesIndexPageSorter or on an actual query ?
| for (int position = 0; position < page.getPositionCount(); position++) { | ||
| long sliceAddress = encodeSyntheticAddress(pageIndex, position); | ||
| // this uses a long[] internally, so cap size to a nice round number for safety | ||
| int resultingSize = valueAddresses.size() + page.getPositionCount(); |
Member
There was a problem hiding this comment.
Maybe just use a long here instead of resultingSize < 0 for detecting overflow.
sopel39
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor refactoring improvements to PagesIndex.
Refactoring
Core engine
This change should not need to be explained to a non-technical end user or system administrator.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: