Show Iceberg table version in SHOW CREATE TABLE

[polaris6]

When doing a show create table operation for a iceberg table, trino does not return the format-version property:

Therefore the content of this part of the document is incorrect:

I made some modifications to show this property. The first step is to create a table:

Before the modification, the result of show create table is like this:

After the modification, the result of show create table is like this:

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[polaris6]

@findepi Hi findepi, excuse me, can you help me to review this pr? In addition, I submitted a cla yesterday, but I haven't received a reply yet, so the current pr submission may fail the verification, which can be ignored for now. Thank you very much!

[findepi]

@polaris6 thank you for your PR!

cc @martint on the CLA question

cc @alexjo2144

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[alexjo2144]

That table is based on org.apache.iceberg.Table#properties so the contents of the table aren't very strict. There could be a key/value entry for anything in this class, if the table was made or altered in Spark https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableProperties.java

I"m not sure how to make that clear in the docs though

[findepi]

The example should include properties a user is most likely to see.
format-version doesn't seem to be one of them, so it's a good change to remove it from here.

let's consider this sufficient for this PR

[polaris6]

In iceberg's metadata file, format-version is an element at the same level as properties and will not be included in
properties. A sample metadata file is as follows：

{
  "format-version" : 1,
  "location" : "hdfs://testOnline/data/iceberg/warehouse/test.db/demo",
  "partition-spec" : [ {
    "name" : "dteventtimestamp_hour",
    "transform" : "hour",
    "source-id" : 5,
    "field-id" : 1000
  } ],
  "properties" : {
    "commit.retry.max-wait-ms" : "3000",
    "max.compact.file.size" : "4194304",
    "commit.retry.total-timeout-ms" : "100000",
    "preserve.snapshot.days" : "3",
    "preserve.snapshot.nums" : "10",
    "write.format.default" : "parquet",
    "max.rewrite.files" : "3000",
    "write.metadata.delete-after-commit.enabled" : "true",
    "commit.retry.num-retries" : "2000",
    "commit.retry.min-wait-ms" : "100"
  },
  "current-snapshot-id" : 1234567890123,
  "...": "..."
}

We can refer to these, show create table returns elements such as format-version, location, partition, etc. $properties returns properties in iceberg metadata.

[findepi]

@polaris6 can you please squash commits and perhaps change commit message to something like the following

Show Iceberg table version in SHOW CREATE TABLE

Include `format_version` table property in `SHOW CREATE TABLE` output.

This also fixes a doc entry about `$properties` system table. The
`format-version` property isn't returned there.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[polaris6]

@findepi Thank you for your suggestion, I resubmitted it, do you think this is ok?

[findepi]

@polaris6 thanks!
can you please make the first line of commit message shorter? it looks quite long.
You can refer to #11980 (comment) for my suggested commit message (the line breaks matter).

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[polaris6]

@findepi Thank you for your suggestion, I resubmitted it.

[findepi]

Thanks!

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[polaris6]

@findepi Hello findepi, sorry to bother you, I fixed the failed test case and submitted a commit, could you please help me to trigger the workflow? After the workflow is executed, I will squash commits.
I'm so sorry, it's really my problem.
I have executed all the verifications of the workflow myself, and I will pay attention in the future. Before submitting the pr to this repository, I will run the workflow test first, and submit it after all the verifications are passed.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[findepi]

@polaris6 please squash the commits and ping here for workflow re-run.
(i wish i could approve it in advance, but i don't see an option for this, sorry)

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[martint]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!