Skip to content

Fix session schema in testRenameTableAcrossSchema #11978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Apr 16, 2022
Merged

Fix session schema in testRenameTableAcrossSchema #11978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...no-raptor-legacy/src/test/java/io/trino/plugin/raptor/legacy/BaseRaptorConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import com.google.common.collect.HashMultimap;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.SetMultimap;
import io.trino.Session;
import io.trino.spi.type.ArrayType;
import io.trino.testing.BaseConnectorTest;
import io.trino.testing.MaterializedResult;
Expand Down Expand Up @@ -111,16 +112,16 @@ public void testRenameTableAcrossSchema()

String schemaName = "test_schema_" + randomTableSuffix();

String renamedTable = schemaName + ".test_rename_new_" + randomTableSuffix();
assertUpdate("ALTER TABLE " + tableName + " RENAME TO " + renamedTable);
String renamedTable = "test_rename_new_" + randomTableSuffix();
assertUpdate("ALTER TABLE " + tableName + " RENAME TO " + schemaName + "." + renamedTable);

assertFalse(getQueryRunner().tableExists(getSession(), tableName));
assertQuery("SELECT x FROM " + renamedTable, "VALUES 123");
assertQuery("SELECT x FROM " + schemaName + "." + renamedTable, "VALUES 123");

assertUpdate("DROP TABLE " + renamedTable);
assertUpdate("DROP TABLE " + schemaName + "." + renamedTable);

assertFalse(getQueryRunner().tableExists(getSession(), tableName));
assertFalse(getQueryRunner().tableExists(getSession(), renamedTable));
assertFalse(getQueryRunner().tableExists(Session.builder(getSession()).setSchema(schemaName).build(), renamedTable));
}

@Override
Expand Down
10 changes: 5 additions & 5 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2115,17 +2115,17 @@ public void testRenameTableAcrossSchema()
String schemaName = "test_schema_" + randomTableSuffix();
assertUpdate("CREATE SCHEMA " + schemaName);

String renamedTable = schemaName + ".test_rename_new_" + randomTableSuffix();
assertUpdate("ALTER TABLE " + tableName + " RENAME TO " + renamedTable);
String renamedTable = "test_rename_new_" + randomTableSuffix();
assertUpdate("ALTER TABLE " + tableName + " RENAME TO " + schemaName + "." + renamedTable);

assertFalse(getQueryRunner().tableExists(getSession(), tableName));
assertQuery("SELECT x FROM " + renamedTable, "VALUES 123");
assertQuery("SELECT x FROM " + schemaName + "." + renamedTable, "VALUES 123");

assertUpdate("DROP TABLE " + renamedTable);
assertUpdate("DROP TABLE " + schemaName + "." + renamedTable);
assertUpdate("DROP SCHEMA " + schemaName);

assertFalse(getQueryRunner().tableExists(getSession(), tableName));
assertFalse(getQueryRunner().tableExists(getSession(), renamedTable));
assertFalse(getQueryRunner().tableExists(Session.builder(getSession()).setSchema(schemaName).build(), renamedTable));
}

@Test
Expand Down