Add test for metastore access count in Delta Lake#11973
Add test for metastore access count in Delta Lake#11973findepi merged 2 commits intotrinodb:masterfrom
Conversation
|
@ebyhr see CI for delta-lake failed |
|
@findepi Fixed CI failure. |
There was a problem hiding this comment.
This is copied from Iceberg's CountingAccessFileHiveMetastore, right?
Let's move the class to trino-hive/src/test/java and share via a test-jar dependency.
When moving, drop "File" from the name (it's a left over)
There was a problem hiding this comment.
Right, moved to Hive module.
There was a problem hiding this comment.
add before Module module, (as you did in TestingDeltaLakePlugin class)
There was a problem hiding this comment.
actually, i think the change here is not required.
You can bind your own metastore via Module module, you just need to set hive.metastore to some unsupported value (eg other).
would that work? i think this is what TestDeltaLakeMetastoreAccessOperations is doing.
There was a problem hiding this comment.
as a followup, this test class can perhaps be simplified with the CountingAccess{File}HiveMetastore class.
i.e. we could remove reflection use from here.
for that, we would need to ensure every method in CountingAccess{File}HiveMetastore is counted, not only selected ones.
Also, rename to CountingAccessHiveMetastore.
fff0769 to
224a252
Compare
Description
Add test for metastore access count in Delta Lake
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.