Fail iceberg optimize for tables with version > 1#11966
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 20, 2022
Merged
Conversation
alexjo2144
approved these changes
Apr 14, 2022
homar
force-pushed
the
homar/prevent_iceberg_optimize_from_running_on_v2_tables
branch
2 times, most recently
from
8a5f31b to
342fc2e
Compare
findepi
approved these changes
Apr 15, 2022
Comment on lines
782
to
783
Member
There was a problem hiding this comment.
nit: fmt: each arg on own line (so a line break after format()
Member
There was a problem hiding this comment.
Suggested change
| // Currently Optimize fails when position deletes files are present in iceberg table | |
| // Currently, Optimize would fail when position deletes files are present in Iceberg table |
homar
force-pushed
the
homar/prevent_iceberg_optimize_from_running_on_v2_tables
branch
from
342fc2e to
06da7c1
Compare
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize will fail anyway for tables that contains delete files.
It is better to fail fast and in a straighforward manner.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: