Skip to content

Minor refactoring in Redis connector#11957

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
polaris6:adjust-redis-connector
Apr 20, 2022
Merged

Minor refactoring in Redis connector#11957
ebyhr merged 1 commit intotrinodb:masterfrom
polaris6:adjust-redis-connector

Conversation

@polaris6
Copy link
Member

@polaris6 polaris6 commented Apr 14, 2022

No description provided.

@cla-bot
Copy link

cla-bot bot commented Apr 14, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 15, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@polaris6 polaris6 requested a review from ebyhr April 15, 2022 11:56
@polaris6
Copy link
Member Author

@ebyhr Hi ebyhr, I submitted a cla yesterday, but I haven't received a reply yet, so the current pr submission may fail the verification, which can be ignored for now. Thank you very much!
企业微信截图_3fef04b7-01da-4025-895d-6cd7af5294f3

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits and improve the commit message:

Minor refactoring to RedisRecordCursor

https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Apr 16, 2022
@ebyhr ebyhr changed the title adjust redis connector Minor refactoring in Redis connector Apr 16, 2022
This also removed the `SET` data type in RedisDataType because it is not used.
@polaris6 polaris6 force-pushed the adjust-redis-connector branch from e869d55 to 331fea2 Compare April 16, 2022 03:04
@cla-bot
Copy link

cla-bot bot commented Apr 16, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@polaris6
Copy link
Member Author

@ebyhr Thank you for your suggestion, I resubmitted it.

@ebyhr
Copy link
Member

ebyhr commented Apr 18, 2022

@polaris6 Contributors list was updated today, but your account doesn't exist. Just in case, did you send CLA with @polaris6 account name?

@polaris6
Copy link
Member Author

polaris6 commented Apr 19, 2022

Hi @ebyhr, the account name is correct, but there is a problem with the signature, I have re-sent the email to Martin, thank you very much for the reminder.

@martint
Copy link
Member

martint commented Apr 20, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Apr 20, 2022
@cla-bot
Copy link

cla-bot bot commented Apr 20, 2022

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr merged commit d7e6efc into trinodb:master Apr 20, 2022
@ebyhr
Copy link
Member

ebyhr commented Apr 20, 2022

Thanks!

@github-actions github-actions bot added this to the 378 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants