Speed up coercion to a single type for IN predicates#11956
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Apr 15, 2022
Merged
Speed up coercion to a single type for IN predicates#11956sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
approved these changes
Apr 14, 2022
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
lgtm % comments % failing test testInvalidTypeArray
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/speedup-in-coercion
branch
from
eabeaab to
80169e6
Compare
sopel39
reviewed
Apr 14, 2022
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/speedup-in-coercion
branch
from
80169e6 to
00cbe34
Compare
Contributor
Author
|
@sopel39 fixed, please merge whenever you want |
wendigo
force-pushed
the
serafin/speedup-in-coercion
branch
from
00cbe34 to
c7063f1
Compare
sopel39
force-pushed
the
serafin/speedup-in-coercion
branch
from
c7063f1 to
d1fb073
Compare
sopel39
approved these changes
Apr 15, 2022
kasiafi
approved these changes
Apr 15, 2022
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Apr 15, 2022
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
sopel39
force-pushed
the
serafin/speedup-in-coercion
branch
from
d1fb073 to
3ffc648
Compare
sopel39
force-pushed
the
serafin/speedup-in-coercion
branch
from
3ffc648 to
2efd3c5
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces complexity of
coerceToSingleTypeby doing less processing and saving type information in batches