Check Connector version in SPI compatibility check

lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/Versions.java

@@ -13,8 +13,8 @@
  */
 package io.trino.plugin.base;
 
+import io.trino.spi.connector.Connector;
 import io.trino.spi.connector.ConnectorContext;
-import io.trino.spi.connector.ConnectorFactory;
 
 import java.util.Optional;
 
@@ -32,10 +32,10 @@ private Versions() {}
      * chooses not to maintain compatibility with older SPI versions, as happens for plugins maintained together with
      * the Trino project.
      */
-    public static void checkSpiVersion(ConnectorContext context, ConnectorFactory connectorFactory)
+    public static void checkSpiVersion(ConnectorContext context, String connectorName, Class<? extends Connector> connectorClass)
     {
         String spiVersion = context.getSpiVersion();
-        Optional<String> pluginVersion = getPluginMavenVersion(connectorFactory);
+        Optional<String> pluginVersion = getPluginMavenVersion(connectorClass);
 
         if (pluginVersion.isEmpty()) {
             // Assume we're in tests. In tests, plugin version is unknown and SPI version may be known, e.g. when running single module's tests from maven.
@@ -47,14 +47,14 @@ public static void checkSpiVersion(ConnectorContext context, ConnectorFactory co
                 format(
                         "Trino SPI version %s does not match %s connector version %s. The connector cannot be used with SPI version other than it was compiled for.",
                         spiVersion,
-                        connectorFactory.getName(),
+                        connectorName,
                         pluginVersion.get()));
     }
 
-    private static Optional<String> getPluginMavenVersion(ConnectorFactory connectorFactory)
+    private static Optional<String> getPluginMavenVersion(Class<? extends Connector> connectorClass)
     {
-        String specificationVersion = connectorFactory.getClass().getPackage().getSpecificationVersion();
-        String implementationVersion = connectorFactory.getClass().getPackage().getImplementationVersion();
+        String specificationVersion = connectorClass.getPackage().getSpecificationVersion();
+        String implementationVersion = connectorClass.getPackage().getImplementationVersion();
         if (specificationVersion == null && implementationVersion == null) {
             // The information comes from jar's Manifest and is not present e.g. when running tests, or from an IDE.
             return Optional.empty();

plugin/trino-accumulo/src/main/java/io/trino/plugin/accumulo/AccumuloConnectorFactory.java

@@ -43,7 +43,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
         requireNonNull(context, "context is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, CONNECTOR_NAME, AccumuloConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorFactory.java

@@ -53,7 +53,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), AtopConnector.class);
 
         try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
             Bootstrap app = new Bootstrap(

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnectorFactory.java

@@ -63,7 +63,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, name, JdbcConnector.class);
 
         Bootstrap app = new Bootstrap(
                 binder -> binder.bind(TypeManager.class).toInstance(context.getTypeManager()),

plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConnectorFactory.java

@@ -41,7 +41,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), BigQueryConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleConnectorFactory.java

@@ -37,7 +37,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), BlackHoleConnector.class);
 
         ListeningScheduledExecutorService executorService = listeningDecorator(newSingleThreadScheduledExecutor(daemonThreadsNamed("blackhole")));
         return new BlackHoleConnector(

plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraConnectorFactory.java

@@ -40,7 +40,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), CassandraConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new MBeanModule(),

plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConnectorFactory.java

@@ -46,7 +46,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), DeltaLakeConnector.class);
 
         ClassLoader classLoader = context.duplicatePluginClassLoader();
         try {

plugin/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/ElasticsearchConnectorFactory.java

@@ -46,7 +46,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), ElasticsearchConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new MBeanModule(),

plugin/trino-example-http/src/main/java/io/trino/plugin/example/ExampleConnectorFactory.java

@@ -39,7 +39,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), ExampleConnector.class);
 
         // A plugin is not required to use Guice; it is just very convenient
         Bootstrap app = new Bootstrap(

plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsConnectorFactory.java

@@ -39,7 +39,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), SheetsConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveConnectorFactory.java

@@ -55,7 +55,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), HiveConnector.class);
 
         ClassLoader classLoader = context.duplicatePluginClassLoader();
         try {

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergConnectorFactory.java

@@ -51,7 +51,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), IcebergConnector.class);
 
         ClassLoader classLoader = context.duplicatePluginClassLoader();
         try {

plugin/trino-jmx/src/main/java/io/trino/plugin/jmx/JmxConnectorFactory.java

@@ -39,7 +39,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), JmxConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new MBeanServerModule(),

plugin/trino-kafka/src/main/java/io/trino/plugin/kafka/KafkaConnectorFactory.java

@@ -51,7 +51,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), KafkaConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new CatalogNameModule(catalogName),

plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisConnectorFactory.java

@@ -46,7 +46,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), KinesisConnector.class);
 
         try {
             Bootstrap app = new Bootstrap(

plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduConnectorFactory.java

@@ -42,7 +42,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), KuduConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-local-file/src/main/java/io/trino/plugin/localfile/LocalFileConnectorFactory.java

@@ -38,7 +38,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), LocalFileConnector.class);
 
         Bootstrap app = new Bootstrap(
                 binder -> binder.bind(NodeManager.class).toInstance(context.getNodeManager()),

plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryConnectorFactory.java

@@ -38,7 +38,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), MemoryConnector.class);
 
         // A plugin is not required to use Guice; it is just very convenient
         Bootstrap app = new Bootstrap(

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoConnectorFactory.java

@@ -49,7 +49,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), MongoConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-phoenix/src/main/java/io/trino/plugin/phoenix/PhoenixConnectorFactory.java

@@ -48,7 +48,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), PhoenixConnector.class);
 
         try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
             Bootstrap app = new Bootstrap(

plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixConnectorFactory.java

@@ -48,7 +48,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), PhoenixConnector.class);
 
         try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
             Bootstrap app = new Bootstrap(

plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConnectorFactory.java

@@ -52,7 +52,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), PinotConnector.class);
 
         ImmutableList.Builder<Module> modulesBuilder = ImmutableList.<Module>builder()
                 .add(new JsonModule())

plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnectorFactory.java

@@ -40,7 +40,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> requiredConfig, ConnectorContext context)
     {
         requireNonNull(requiredConfig, "requiredConfig is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), PrometheusConnector.class);
 
         try {
             // A plugin is not required to use Guice; it is just very convenient

plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/RaptorConnectorFactory.java

@@ -63,7 +63,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), RaptorConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new CatalogNameModule(catalogName),

plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisConnectorFactory.java

@@ -53,7 +53,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
     {
         requireNonNull(catalogName, "catalogName is null");
         requireNonNull(config, "config is null");
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), RedisConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new JsonModule(),

plugin/trino-thrift/src/main/java/io/trino/plugin/thrift/ThriftConnectorFactory.java

@@ -51,7 +51,7 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), ThriftConnector.class);
 
         Bootstrap app = new Bootstrap(
                 new MBeanModule(),

plugin/trino-tpcds/src/main/java/io/trino/plugin/tpcds/TpcdsConnectorFactory.java

@@ -13,6 +13,7 @@
  */
 package io.trino.plugin.tpcds;
 
+import com.google.common.collect.ImmutableMap;
 import io.trino.spi.NodeManager;
 import io.trino.spi.connector.Connector;
 import io.trino.spi.connector.ConnectorContext;
@@ -58,42 +59,53 @@ public String getName()
     @Override
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
-        checkSpiVersion(context, this);
+        checkSpiVersion(context, getName(), TpcdsConnector.class);
+        return new TpcdsConnector(config, context);
+    }
+
+    private class TpcdsConnector
+            implements Connector
+    {
+        private final int splitsPerNode;
+        private final NodeManager nodeManager;
+        private final Map<String, String> config;
+
+        public TpcdsConnector(Map<String, String> config, ConnectorContext context)
+        {
+            this.splitsPerNode = getSplitsPerNode(config);
+            this.nodeManager = context.getNodeManager();
+            this.config = ImmutableMap.copyOf(config);
+        }
 
-        int splitsPerNode = getSplitsPerNode(config);
-        NodeManager nodeManager = context.getNodeManager();
-        return new Connector()
+        @Override
+        public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
         {
-            @Override
-            public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly, boolean autoCommit)
-            {
-                return TpcdsTransactionHandle.INSTANCE;
-            }
-
-            @Override
-            public ConnectorMetadata getMetadata(ConnectorSession session, ConnectorTransactionHandle transactionHandle)
-            {
-                return new TpcdsMetadata();
-            }
-
-            @Override
-            public ConnectorSplitManager getSplitManager()
-            {
-                return new TpcdsSplitManager(nodeManager, splitsPerNode, isWithNoSexism(config));
-            }
-
-            @Override
-            public ConnectorRecordSetProvider getRecordSetProvider()
-            {
-                return new TpcdsRecordSetProvider();
-            }
-
-            @Override
-            public ConnectorNodePartitioningProvider getNodePartitioningProvider()
-            {
-                return new TpcdsNodePartitioningProvider(nodeManager, splitsPerNode);
-            }
-        };
+            return TpcdsTransactionHandle.INSTANCE;
+        }
+
+        @Override
+        public ConnectorMetadata getMetadata(ConnectorSession session, ConnectorTransactionHandle transactionHandle)
+        {
+            return new TpcdsMetadata();
+        }
+
+        @Override
+        public ConnectorSplitManager getSplitManager()
+        {
+            return new TpcdsSplitManager(nodeManager, splitsPerNode, isWithNoSexism(config));
+        }
+
+        @Override
+        public ConnectorRecordSetProvider getRecordSetProvider()
+        {
+            return new TpcdsRecordSetProvider();
+        }
+
+        @Override
+        public ConnectorNodePartitioningProvider getNodePartitioningProvider()
+        {
+            return new TpcdsNodePartitioningProvider(nodeManager, splitsPerNode);
+        }
     }
 
     private int getSplitsPerNode(Map<String, String> properties)