Conversation
Previously, `assertExpectedPartitions` checked whether expected partitions are present. After the change, it still does that, but also verifies no unexpected partitions are present.
Member
Author
|
@damnMeddlingKid can you please take a look? |
findepi
added
the
no-release-notes
Member
|
Looks good to me. Thanks for the quick turn around !. |
hashhar
approved these changes
Apr 13, 2022
findepi
deleted the
findepi/assert-no-other-partitions-in-assertexpectedpartitions-baa3f0
branch
findepi
restored the
findepi/assert-no-other-partitions-in-assertexpectedpartitions-baa3f0
branch
findepi
deleted the
findepi/assert-no-other-partitions-in-assertexpectedpartitions-baa3f0
branch
findepi
restored the
findepi/assert-no-other-partitions-in-assertexpectedpartitions-baa3f0
branch
findepi
deleted the
findepi/assert-no-other-partitions-in-assertexpectedpartitions-baa3f0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
assertExpectedPartitionschecked whether expectedpartitions are present. After the change, it still does that, but also
verifies no unexpected partitions are present.
Fixes #11904
Note: this PR runs with secrets