Support skipping control queries in verifier#11921
Merged
arhimondr merged 2 commits intotrinodb:masterfrom Apr 14, 2022
Merged
Conversation
losipiuk
reviewed
Apr 13, 2022
Comment on lines
+548
to
+554
Member
There was a problem hiding this comment.
those look unrelated - could be separate commit.
Contributor
Author
There was a problem hiding this comment.
This is a part of the Record query id for failed queries in verifier. Maybe i should change the commit message to something like Record query id and runtime information for failed queries in verifier?
losipiuk
approved these changes
Apr 13, 2022
linzebing
approved these changes
Apr 13, 2022
arhimondr
force-pushed
the
verifier-skip-control
branch
from
4b2143c to
8bc0e13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Useful when trying to use verifier as a simple tool for running a list of queries without any additional verifications
Improvement
Verifier
-Related issues, pull requests, and links
-Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: