Extract LdapClient to plugin-toolkit#11909
Merged
Praveen2112 merged 2 commits intotrinodb:masterfrom Apr 28, 2022
Merged
Conversation
Praveen2112
force-pushed
the
praveen/002/ldap_cleanup
branch
3 times, most recently
from
64443a2 to
7af157d
Compare
Praveen2112
requested review from
aczajkowski,
kokosing,
lukasz-walkiewicz and
s2lomon
Praveen2112
force-pushed
the
praveen/002/ldap_cleanup
branch
from
7af157d to
7e5543e
Compare
kokosing
approved these changes
Apr 13, 2022
lukasz-walkiewicz
approved these changes
Apr 13, 2022
...word-authenticators/src/main/java/io/trino/plugin/password/ldap/LdapAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/002/ldap_cleanup
branch
from
7e5543e to
73e64db
Compare
s2lomon
approved these changes
Apr 19, 2022
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/ldap/LdapClient.java
Outdated
Show resolved
Hide resolved
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/ldap/LdapQuery.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
I would prefer all this kind ldap queries be hidden behind additional additional service like class named Ldap or LdapService, LdapGateway/Repository or something, so that the context of what's going on is clear there and the logic connected with ldap query is not entangled with the interpretation of it for Authentication purposes.
...o-password-authenticators/src/main/java/io/trino/plugin/password/ldap/LdapAuthenticator.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/002/ldap_cleanup
branch
from
73e64db to
18fb12f
Compare
Member
Author
|
@s2lomon AC |
s2lomon
approved these changes
Apr 28, 2022
Member
s2lomon
left a comment
s2lomon
left a comment
There was a problem hiding this comment.
Good job, I like how it's done.
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This extraction allows us to reuse the LdapClient across multiple modules.
Refactoring around LdapClient
Password authenticators
Extract LdapClient to plugin toolkit
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: