Improve storage credential explanation#11905
Merged
electrum merged 1 commit intotrinodb:masterfrom Jun 10, 2022
Merged
Conversation
mosabua
reviewed
Apr 11, 2022
m57lyra
approved these changes
Apr 12, 2022
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
464159d to
4a4ee81
Compare
mosabua
requested changes
Apr 13, 2022
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
2 times, most recently
from
522dec0 to
e8f0640
Compare
findinpath
reviewed
Apr 25, 2022
findinpath
reviewed
Apr 25, 2022
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
e8f0640 to
064f480
Compare
mfzarko
suggested changes
Apr 28, 2022
Member
mfzarko
left a comment
mfzarko
left a comment
There was a problem hiding this comment.
LGTM,
I feel a core-site.xml config snippet as an example would best.
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
064f480 to
b8617db
Compare
rosewms
commented
Apr 29, 2022
mosabua
reviewed
May 3, 2022
mosabua
reviewed
May 3, 2022
mosabua
reviewed
May 3, 2022
mosabua
reviewed
May 3, 2022
mosabua
requested changes
May 3, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
This adds more info at this stage but does not make anything clearer. Please revisit.
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
b8617db to
d412370
Compare
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
d412370 to
223bd07
Compare
Contributor
Author
|
@mosabua updated PR with the reorganized content to emphasize using the catalog properties. Additionally clarifies the |
mosabua
requested changes
May 26, 2022
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
223bd07 to
f1ab18e
Compare
rosewms
force-pushed
the
rw-hadoop-site-credential-storage
branch
from
f1ab18e to
7727e10
Compare
electrum
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core-site.xmland improve clarifyDocumentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: