Skip to content

Delay checking for user input in CLI client#11899

Merged
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:cli-check-input-later
Apr 20, 2022
Merged

Delay checking for user input in CLI client#11899
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:cli-check-input-later

Conversation

@nineinchnick
Copy link
Member

Description

Avoid adding about 200ms of delay to very short queries by not checking user input in the first 300ms of query execution. Queries can still be canceled, as CTRL+C signal handling is setup earlier in Query.renderOutput.

Is this change a fix, improvement, new feature, refactoring, or other?

fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

cli client

How would you describe this change to a non-technical end user or system administrator?

Avoid adding about 200ms of delay to very short queries.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# CLI client
* Avoid adding about 200ms of delay to very short queries. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 11, 2022
@nineinchnick
Copy link
Member Author

I tested this manually and it seems to resolve the issue. Also, looks like my reflex is average - I can't cancel the query quicker than ~90ms :-)

@hashhar hashhar requested a review from electrum April 20, 2022 08:13
@electrum electrum merged commit 1cf972e into trinodb:master Apr 20, 2022
@github-actions github-actions bot added this to the 378 milestone Apr 20, 2022
@nineinchnick nineinchnick deleted the cli-check-input-later branch November 2, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

CLI progress adds delay to every query

2 participants