Allow to disable progress in CLI interactive mode#11894
Merged
electrum merged 1 commit intotrinodb:masterfrom Apr 20, 2022
Merged
Allow to disable progress in CLI interactive mode#11894electrum merged 1 commit intotrinodb:masterfrom
electrum merged 1 commit intotrinodb:masterfrom
Conversation
hashhar
approved these changes
Apr 20, 2022
Member
hashhar
left a comment
There was a problem hiding this comment.
LGTM from me.
@electrum Do you want to take a look? https://github.com/trinodb/trino/pull/11899/files is an alternative it seems.
Member
Author
It's not an alternative. Both can be merged. This PR is only about being able to disable progress when there's a TTY (interactive mode). This is the opposite of enabling progress in batch mode. |
Member
|
We should add docs for that .. can you send a PR @nineinchnick ? |
Member
Author
Terribly sorry I forgot about that. Here it is, I checked what other options were not documented yet and added a new section: #12075 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow disabling progress reporting during query executing in the CLI client by specifying
--no-progress. This makes short queries execute a bit faster since it avoids the delay introduced by waiting for key presses. It doesn't fix the root cause of the issue, but it gives more control to users. It doesn't add a new flag, just a negative variant of the existing one. Queries can still be interrupted withCTRL+C.new feature
CLI client
Allow disabling progress reporting during query executing in the CLI client by specifying
--no-progress.Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: