Skip to content

Allow to disable progress in CLI interactive mode#11894

Merged
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:cli-no-progress
Apr 20, 2022
Merged

Allow to disable progress in CLI interactive mode#11894
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:cli-no-progress

Conversation

@nineinchnick
Copy link
Member

Description

Allow disabling progress reporting during query executing in the CLI client by specifying --no-progress. This makes short queries execute a bit faster since it avoids the delay introduced by waiting for key presses. It doesn't fix the root cause of the issue, but it gives more control to users. It doesn't add a new flag, just a negative variant of the existing one. Queries can still be interrupted with CTRL+C.

Is this change a fix, improvement, new feature, refactoring, or other?

new feature

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

CLI client

How would you describe this change to a non-technical end user or system administrator?

Allow disabling progress reporting during query executing in the CLI client by specifying --no-progress.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# CLI
* Allow disabling progress reporting during query executing in the CLI client by specifying `--no-progress` ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 10, 2022
@hashhar hashhar requested a review from electrum April 20, 2022 08:13
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me.

@electrum Do you want to take a look? https://github.com/trinodb/trino/pull/11899/files is an alternative it seems.

@nineinchnick
Copy link
Member Author

nineinchnick commented Apr 20, 2022

https://github.com/trinodb/trino/pull/11899/files is an alternative it seems.

It's not an alternative. Both can be merged. This PR is only about being able to disable progress when there's a TTY (interactive mode). This is the opposite of enabling progress in batch mode.

@electrum electrum merged commit 9c5c8f8 into trinodb:master Apr 20, 2022
@github-actions github-actions bot added this to the 378 milestone Apr 20, 2022
@mosabua
Copy link
Member

mosabua commented Apr 20, 2022

We should add docs for that .. can you send a PR @nineinchnick ?

@nineinchnick nineinchnick deleted the cli-no-progress branch April 21, 2022 05:29
@nineinchnick
Copy link
Member Author

We should add docs for that .. can you send a PR @nineinchnick ?

Terribly sorry I forgot about that. Here it is, I checked what other options were not documented yet and added a new section: #12075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants