Skip to content

Add Windows instructions for running Trino CLI#11882

Merged
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/trino-cli-windows-os
Apr 21, 2022
Merged

Add Windows instructions for running Trino CLI#11882
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/trino-cli-windows-os

Conversation

@Jessie212
Copy link
Contributor

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation only.

How would you describe this change to a non-technical end user or system administrator?

Add Windows instructions for running the Trino CLI.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 8, 2022
@Jessie212 Jessie212 requested review from hashhar and mosabua April 8, 2022 18:46
@mosabua mosabua removed the request for review from hashhar April 8, 2022 21:20
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss this more when you are available.Essentially we want to say that you can also start with java -jar ... and this is necessary for Windows users and anybody else if the jar directly does not work

@findepi findepi requested a review from electrum April 9, 2022 08:31
@Jessie212 Jessie212 force-pushed the jt/trino-cli-windows-os branch 2 times, most recently from 3bb5bf3 to 7520a49 Compare April 19, 2022 21:27
@Jessie212 Jessie212 force-pushed the jt/trino-cli-windows-os branch from 7520a49 to e96c859 Compare April 19, 2022 21:30
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mosabua mosabua requested a review from hashhar April 19, 2022 21:30
@martint martint merged commit 8b2cce4 into trinodb:master Apr 21, 2022
@github-actions github-actions bot added this to the 378 milestone Apr 21, 2022
@Jessie212 Jessie212 deleted the jt/trino-cli-windows-os branch May 9, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants