Skip to content

Add delta catalog to development server #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
May 24, 2022
Merged

Add delta catalog to development server #11845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e418e
Add delta catalog settings
findinpath Apr 7, 2022
7b34b4f
Expose MinIO web console
findinpath May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Minio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class Minio
private static final String MINIO_RELEASE = "RELEASE.2021-07-15T22-27-34Z";

private static final int MINIO_PORT = 9080; // minio uses 9000 by default, which conflicts with hadoop
private static final int MINIO_CONSOLE_PORT = 9001;

private final PortBinder portBinder;

Expand Down Expand Up @@ -74,12 +75,13 @@ private DockerContainer createMinioContainer()
.put("MINIO_ACCESS_KEY", MINIO_ACCESS_KEY)
.put("MINIO_SECRET_KEY", MINIO_SECRET_KEY)
.buildOrThrow())
.withCommand("server", "--address", format("0.0.0.0:%d", MINIO_PORT), "/data")
.withCommand("server", "--address", format("0.0.0.0:%d", MINIO_PORT), "--console-address", format("0.0.0.0:%d", MINIO_CONSOLE_PORT), "/data")
.withStartupCheckStrategy(new IsRunningStartupCheckStrategy())
.waitingFor(forSelectedPorts(MINIO_PORT))
.withStartupTimeout(Duration.ofMinutes(1));

portBinder.exposePort(container, MINIO_PORT);
portBinder.exposePort(container, MINIO_CONSOLE_PORT);

return container;
}
Expand Down
19 changes: 19 additions & 0 deletions testing/trino-server-dev/etc/catalog/delta.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
connector.name=delta-lake

# Configuration appropriate for Hive as started by product test environment, e.g.
# testing/bin/ptl env up --environment multinode-minio-data-lake --without-trino
# On Mac, this additionally requires that you add "<your external IP> hadoop-master" to /etc/hosts
hive.metastore.uri=thrift://localhost:9083

# MinIO uses 9000 by default, but this change conflicts with Hadoop
hive.s3.endpoint=http://localhost:9080
hive.s3.path-style-access=true
hive.s3.ssl.enabled=false
hive.s3.aws-access-key=minio-access-key
hive.s3.aws-secret-key=minio-secret-key

# Fail-fast in development
hive.metastore.thrift.client.max-retry-time=1s
hive.s3.max-client-retries=1
# Enable write support for all supported file systems in development
delta.enable-non-concurrent-writes=true
1 change: 1 addition & 0 deletions testing/trino-server-dev/etc/config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ plugin.bundles=\
../../plugin/trino-resource-group-managers/pom.xml,\
../../plugin/trino-password-authenticators/pom.xml, \
../../plugin/trino-iceberg/pom.xml,\
../../plugin/trino-delta-lake/pom.xml,\
../../plugin/trino-blackhole/pom.xml,\
../../plugin/trino-cassandra/pom.xml,\
../../plugin/trino-memory/pom.xml,\
Expand Down