Upgrade Error Prone to 2.12.0#11824
Merged
kokosing merged 4 commits intotrinodb:masterfrom Apr 25, 2022
Merged
Conversation
Contributor
Author
|
Oh great, I thought this only happens inside my IDE: |
Member
|
|
Contributor
Author
ksobolew
force-pushed
the
kudi/error-prone-2.12
branch
from
3cdb779 to
1760559
Compare
kokosing
approved these changes
Apr 7, 2022
findepi
reviewed
Apr 7, 2022
findepi
reviewed
Apr 7, 2022
core/trino-main/src/test/java/io/trino/sql/gen/TestExpressionCompiler.java
Outdated
Show resolved
Hide resolved
This suppresses an error from Error Prone about comparing boxed primitived using identity comparison. This is usually a bug, but it seems that this was intended here, based on the existing suppression. (Also, `BigDecimal` is not really a boxed primitive.)
`DoubleBraceInitialization` got upgraded to ERROR by default, so we can remove it from the list of checks upgraded explicitly. There is a bunch of spurious warnings about unread fields, which are used in tests in a declarative way. Also, two comparison of `Boolean` values using identity comparison, which should be OK (`Boolean` is always interned), but let's make unboxing explicit.
ksobolew
force-pushed
the
kudi/error-prone-2.12
branch
from
1760559 to
50af90c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement
Static analysis
Better compile-time checks for bugs.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: