Conversation
ebyhr
changed the title
Additionally, deny creating tables in a schema where it doesn't exist.
ebyhr
force-pushed
the
ebi/test-create-table-schema-not-found
branch
2 times, most recently
from
86bf16f to
768b6cb
Compare
Member
Author
|
CI hit #11764 |
findepi
approved these changes
Apr 6, 2022
Member
There was a problem hiding this comment.
remove the test override, this should be handed by the check of the conenctor behavior
Member
There was a problem hiding this comment.
remove (it's kind of obvious this is not "the test" for create table)
ebyhr
force-pushed
the
ebi/test-create-table-schema-not-found
branch
from
768b6cb to
844d935
Compare
hashhar
approved these changes
Apr 6, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add BaseConnectorTest test to verify failure when creating tables in a schema where it doesn't exist. Also, add support for creating and dropping schemas in Accumulo connector.
Fixes #11794
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: