Ignore finished tasks when computing memory usage for stage#11801
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Apr 6, 2022
Merged
Ignore finished tasks when computing memory usage for stage#11801losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk merged 2 commits intotrinodb:masterfrom
Conversation
arhimondr
approved these changes
Apr 5, 2022
losipiuk
force-pushed
the
lo/fix-used-memory-accounting
branch
from
466307a to
a84708a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignore finished tasks when computing memory usage for stage.
Without the fix stage level statistics for peak and current memory were off when task retries happened.
bugfix
engine
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: