Skip to content

Do not enforce memory limits for fault tolerant queries#11786

Merged
arhimondr merged 2 commits intotrinodb:masterfrom
arhimondr:disable-memory-limit-for-tardigrade-queries
Apr 6, 2022
Merged

Do not enforce memory limits for fault tolerant queries#11786
arhimondr merged 2 commits intotrinodb:masterfrom
arhimondr:disable-memory-limit-for-tardigrade-queries

Conversation

@arhimondr
Copy link
Copy Markdown
Contributor

Description

LowMemoryKiller is responsible for freeing up the memory if necessary

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Core

How would you describe this change to a non-technical end user or system administrator?

-

Related issues, pull requests, and links

-

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 5, 2022
@arhimondr arhimondr requested review from linzebing and losipiuk April 5, 2022 00:52
Copy link
Copy Markdown
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change some documentation?

LowMemoryKiller is responsible for freeing up the memory if necessary
@arhimondr arhimondr force-pushed the disable-memory-limit-for-tardigrade-queries branch from 90e3a7a to 88dc9b8 Compare April 5, 2022 22:21
@arhimondr
Copy link
Copy Markdown
Contributor Author

Updated

@github-actions github-actions bot added the docs label Apr 5, 2022
@arhimondr arhimondr merged commit 9488328 into trinodb:master Apr 6, 2022
@arhimondr arhimondr deleted the disable-memory-limit-for-tardigrade-queries branch April 6, 2022 17:44
@github-actions github-actions bot added this to the 376 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants