-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add MySQL automatic Join pushdown test #11752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
findepi
merged 1 commit into
trinodb:master
from
findepi:findepi/add-mysql-automatic-join-pushdown-test-122ad1
Apr 1, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
79 changes: 79 additions & 0 deletions
79
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlAutomaticJoinPushdown.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.mysql; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.collect.ImmutableMap; | ||
| import io.trino.plugin.jdbc.BaseAutomaticJoinPushdownTest; | ||
| import io.trino.testing.MaterializedRow; | ||
| import io.trino.testing.QueryRunner; | ||
| import org.jdbi.v3.core.Handle; | ||
| import org.jdbi.v3.core.Jdbi; | ||
| import org.testng.SkipException; | ||
|
|
||
| import static io.trino.plugin.mysql.MySqlQueryRunner.createMySqlQueryRunner; | ||
| import static java.lang.String.format; | ||
|
|
||
| public class TestMySqlAutomaticJoinPushdown | ||
| extends BaseAutomaticJoinPushdownTest | ||
| { | ||
| private TestingMySqlServer mySqlServer; | ||
|
|
||
| @Override | ||
| protected QueryRunner createQueryRunner() | ||
| throws Exception | ||
| { | ||
| // Using MySQL 8.0.15 because test is sensitive to quality of NDV estimation and 5.5.46 we use | ||
| // in other places does very poor job; for 10000 row table with 1000 distinct keys it estimates NDV at ~2500 | ||
| mySqlServer = closeAfterClass(new TestingMySqlServer("mysql:8.0.15", false)); | ||
|
|
||
| return createMySqlQueryRunner( | ||
| mySqlServer, | ||
| ImmutableMap.of(), | ||
| ImmutableMap.<String, String>builder() | ||
| .put("metadata.cache-ttl", "0m") | ||
| .put("metadata.cache-missing", "false") | ||
| .buildOrThrow(), | ||
| ImmutableList.of()); | ||
| } | ||
|
|
||
| @Override | ||
| public void testJoinPushdownWithEmptyStatsInitially() | ||
| { | ||
| throw new SkipException("MySQL statistics are automatically collected"); | ||
| } | ||
|
|
||
| @Override | ||
| protected void gatherStats(String tableName) | ||
| { | ||
| for (MaterializedRow row : computeActual("SHOW COLUMNS FROM " + tableName)) { | ||
| String columnName = (String) row.getField(0); | ||
| String columnType = (String) row.getField(1); | ||
| if (columnType.startsWith("varchar")) { | ||
| // varchar index require length | ||
| continue; | ||
| } | ||
| onRemoteDatabase(format("CREATE INDEX \"%2$s\" ON %1$s (\"%2$s\")", tableName, columnName).replace("\"", "`")); | ||
| } | ||
| onRemoteDatabase("ANALYZE TABLE " + tableName.replace("\"", "`")); | ||
| } | ||
|
|
||
| protected void onRemoteDatabase(String sql) | ||
| { | ||
| try (Handle handle = Jdbi.open(() -> mySqlServer.createConnection())) { | ||
| handle.execute("USE tpch"); | ||
| handle.execute(sql); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC this is required for some reason? Please add a comment if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk, will let @wendigo speak to this