Skip to content

Populate TPCH tables in Delta Lake query runner#11717

Merged
findepi merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-lake-query-runner
Mar 31, 2022
Merged

Populate TPCH tables in Delta Lake query runner#11717
findepi merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-lake-query-runner

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 30, 2022

Description

Populate TPCH tables in Delta Lake query runner

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@ebyhr ebyhr added maintenance Project maintenance task no-release-notes This pull request does not require release notes entry labels Mar 30, 2022
@cla-bot cla-bot bot added the cla-signed label Mar 30, 2022
@ebyhr ebyhr force-pushed the ebi/delta-lake-query-runner branch from 49fa842 to b15f33a Compare March 30, 2022 08:50
@ebyhr ebyhr requested review from findepi and jirassimok March 30, 2022 08:56
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this gone?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert if necessary.

@ebyhr ebyhr force-pushed the ebi/delta-lake-query-runner branch from b15f33a to 5c00dac Compare March 30, 2022 09:22
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 30, 2022

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebyhr ebyhr force-pushed the ebi/delta-lake-query-runner branch from 5c00dac to 374882b Compare March 30, 2022 23:16
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 31, 2022

@findepi I moved CREATE SCHEMA tpch to main method. Could you please take another look?

@findepi
Copy link
Copy Markdown
Member

findepi commented Mar 31, 2022

still LGTM :)

@findepi findepi merged commit c9ac1c1 into trinodb:master Mar 31, 2022
@github-actions github-actions bot added this to the 376 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants