Add test coverage for data size reported by Iceberg connector#11711
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 30, 2022
Merged
Add test coverage for data size reported by Iceberg connector#11711ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
ebyhr
added
test
no-release-notes
findepi
reviewed
Mar 30, 2022
| " ('a_double', NULL, NULL, 0.5e0, NULL, '1.0', '1.0'), " + | ||
| " ('a_short_decimal', NULL, NULL, 0.5e0, NULL, '1.0', '1.0'), " + | ||
| " ('a_long_decimal', NULL, NULL, 0.5e0, NULL, '11.0', '11.0'), " + | ||
| " ('a_varchar', " + (format == PARQUET ? "87e0" : "NULL") + ", NULL, 0.5e0, NULL, NULL, NULL), " + |
Member
There was a problem hiding this comment.
is it always exactly 87?
can you please run iceberg module on a CI couple times?
Member
Author
There was a problem hiding this comment.
Ran stress test (30 attempts) in #11727 and the value seems stable.
findepi
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test coverage for data size reported by Iceberg connector.
testTruncateTextTransform&testAllAvailableTypesmentioned "the size is varying", but 10/10 invocations succeeded.Fixes #8649
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: