Allow configuration duration for completion of dynamic filters in Delta#11709
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 6, 2022
Merged
Allow configuration duration for completion of dynamic filters in Delta#11709ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Member
There was a problem hiding this comment.
Use unmodifiableFuture here to simulate the actual code from DynamicFilterService
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitSource.java
Outdated
Show resolved
Hide resolved
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
...a-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Mar 30, 2022
losipiuk
approved these changes
Apr 1, 2022
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
You may want to Drop overrides of enableDynamicFiltering and move setting of dynamic_filtering_wait_timeout to superclass as it is supported by all of Hive/Iceberg/Delta now.
Member
Author
|
Let me handle the refactoring later when I have the time. |
ebyhr
force-pushed
the
ebi/delta-lake-df-timeout
branch
from
599522a to
a29d05f
Compare
This was referenced Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow configuration duration for completion of dynamic filters in Delta
Fixes #11600
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: