Skip to content

Support database event client in verifier#11707

Merged
arhimondr merged 3 commits intotrinodb:masterfrom
arhimondr:verifier-mysql-listener
Apr 1, 2022
Merged

Support database event client in verifier#11707
arhimondr merged 3 commits intotrinodb:masterfrom
arhimondr:verifier-mysql-listener

Conversation

@arhimondr
Copy link
Copy Markdown
Contributor

Description

Support writing information about queries executed with verifier into a database

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

verifier

How would you describe this change to a non-technical end user or system administrator?

Verifier is a tool that allows to replay queries on a Trino cluster for testing purposes. When verifier executes a query it generates an internal event containing query id and some basic statistics. This patch allows to configure verifier to store this information into a database.

Related issues, pull requests, and links

-

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

(verifier is currently not documented anywhere)

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Copy Markdown
Member

@linzebing linzebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have documentation related to verifier?

@arhimondr arhimondr force-pushed the verifier-mysql-listener branch from 21ba0e4 to 4cb9508 Compare March 31, 2022 21:50
@arhimondr
Copy link
Copy Markdown
Contributor Author

Do we have documentation related to verifier?

There's a README file, but it is very basic. I don't think this tool has been widely advertised.

@arhimondr arhimondr merged commit 9c39617 into trinodb:master Apr 1, 2022
@arhimondr arhimondr deleted the verifier-mysql-listener branch April 1, 2022 01:04
@github-actions github-actions bot added this to the 376 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants