Skip to content

Use session data provider in SingleStore date type test#11690

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:use-dataprovider-in-singlestore-date-type-test
Mar 29, 2022
Merged

Use session data provider in SingleStore date type test#11690
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:use-dataprovider-in-singlestore-date-type-test

Conversation

@tangjiangling
Copy link
Copy Markdown
Member

@tangjiangling tangjiangling commented Mar 28, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Just SingleStore type mapping tests.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

Related #11373

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2022
@tangjiangling tangjiangling changed the title Use dataprovider in singlestore date type test Use session data provider in singlestore date type test Mar 28, 2022
@tangjiangling tangjiangling added no-release-notes This pull request does not require release notes entry test labels Mar 28, 2022
@tangjiangling tangjiangling marked this pull request as ready for review March 28, 2022 13:48
@tangjiangling tangjiangling requested a review from ebyhr March 28, 2022 13:48
@tangjiangling tangjiangling changed the title Use session data provider in singlestore date type test Use session data provider in SingleStore date type test Mar 28, 2022
@tangjiangling tangjiangling force-pushed the use-dataprovider-in-singlestore-date-type-test branch from 1b00116 to 470575e Compare March 29, 2022 04:03
@ebyhr ebyhr merged commit b89a7c9 into trinodb:master Mar 29, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 29, 2022

Merged, thanks!

@tangjiangling tangjiangling deleted the use-dataprovider-in-singlestore-date-type-test branch March 29, 2022 05:47
@github-actions github-actions bot added this to the 376 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry test

Development

Successfully merging this pull request may close these issues.

2 participants