Skip to content

Disable failing test in Kudu connector#11680

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/kudu-disable-test
Mar 26, 2022
Merged

Disable failing test in Kudu connector#11680
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/kudu-disable-test

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 26, 2022

No description provided.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Mar 26, 2022
@cla-bot cla-bot bot added the cla-signed label Mar 26, 2022
@ebyhr ebyhr force-pushed the ebi/kudu-disable-test branch from 4c77fc4 to bad363c Compare March 26, 2022 07:02
@ebyhr ebyhr requested a review from Praveen2112 March 26, 2022 07:04
hashhar
hashhar approved these changes Mar 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a logical conflict?

EDIT: Yes, seems like it was added in 37b6f36

@ebyhr ebyhr mentioned this pull request Mar 26, 2022
Merged
@ebyhr ebyhr changed the title Disable rename test in Kudu without schema emulation Disable rename table test in Kudu without schema emulation Mar 26, 2022
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 26, 2022 •
edited
Loading

Going to disable testDeleteWithLike as well.

Error:  Failures: 
Error:    TestKuduLatestWithDisabledInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime
Error:    TestKuduLatestWithEmptyInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime
Error:    TestKuduLatestWithStandardInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime
Error:    TestKuduWithDisabledInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime
Error:    TestKuduWithEmptyInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime
Error:    TestKuduWithStandardInferSchemaConnectorTest>BaseConnectorTest.testDeleteWithLike:2409->BaseConnectorTest.skipTestUnlessSupportsDeletes:2522 » Runtime

@ebyhr ebyhr force-pushed the ebi/kudu-disable-test branch from bad363c to 3b659c1 Compare March 26, 2022 08:01
@ebyhr ebyhr changed the title Disable rename table test in Kudu without schema emulation Disable failing test in Kudu connector Mar 26, 2022
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 26, 2022

@hashhar Could you please take another look?

@ebyhr ebyhr merged commit ddb891a into trinodb:master Mar 26, 2022
@ebyhr ebyhr deleted the ebi/kudu-disable-test branch March 26, 2022 12:03
@github-actions github-actions bot added this to the 375 milestone Mar 26, 2022
@mosabua mosabua mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hashhar hashhar hashhar approved these changes

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

Assignees

No one assigned

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Milestone

375

Development

Successfully merging this pull request may close these issues.

2 participants

@ebyhr @hashhar