Replace assertTrue/assertFalse with AssertJ assertions#11665
Replace assertTrue/assertFalse with AssertJ assertions#11665hashhar merged 1 commit intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Overall a very welcome change.
However in some of the assertions the error message helped "explain" why the assertion exists. Can we add those back via assertThat(...).as("message")...?
nastra
force-pushed
the
assertion-improvements
branch
from
952ab9b to
cf3fced
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
nastra
force-pushed
the
assertion-improvements
branch
from
cf3fced to
58fd5bb
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
makes sense @hashhar, I added those "explaining" messages back. thanks for the review |
nastra
force-pushed
the
assertion-improvements
branch
from
58fd5bb to
4cc57b8
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViews.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViews.java
Outdated
Show resolved
Hide resolved
The reason for these changes is because the AssertJ assertions generally provide the actual values when an assertion fails. This helps a lot when understanding why something failed on CI, while `assertTrue`/`assertFalse` checks don't provide that kind of information
nastra
force-pushed
the
assertion-improvements
branch
from
4cc57b8 to
4f5e76e
Compare
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViews.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViews.java
Show resolved
Hide resolved
hashhar
added
test
no-release-notes
2 participants
The reason for these improvements is because the AssertJ assertions generally
provide the actual values when an assertion fails.
This helps a lot when understanding why something failed on CI, while
assertTrue/assertFalsechecks don't provide that kind of information