Skip to content

Use session data provider in SQL Server date mapping test#11663

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:use-dataprovider-in-sqlserver-date-type-test
Mar 29, 2022
Merged

Use session data provider in SQL Server date mapping test#11663
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:use-dataprovider-in-sqlserver-date-type-test

Conversation

@tangjiangling
Copy link
Member

@tangjiangling tangjiangling commented Mar 25, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Just SQL Server type mapping tests.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

Related #11373

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2022
@tangjiangling tangjiangling marked this pull request as ready for review March 25, 2022 07:59
@tangjiangling tangjiangling requested a review from hashhar March 25, 2022 07:59
@tangjiangling tangjiangling added the no-release-notes This pull request does not require release notes entry label Mar 25, 2022
@findepi findepi added the test label Mar 25, 2022
@tangjiangling tangjiangling force-pushed the use-dataprovider-in-sqlserver-date-type-test branch from d66095b to 5c0b01e Compare March 29, 2022 06:33
@ebyhr ebyhr merged commit 1311fbc into trinodb:master Mar 29, 2022
@ebyhr
Copy link
Member

ebyhr commented Mar 29, 2022

Merged, thanks!

@tangjiangling tangjiangling deleted the use-dataprovider-in-sqlserver-date-type-test branch March 29, 2022 08:24
@github-actions github-actions bot added this to the 376 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry test

Development

Successfully merging this pull request may close these issues.

3 participants