Clarify documentation of the Oracle connection-url string#11656
Merged
hashhar merged 1 commit intotrinodb:masterfrom Mar 26, 2022
Merged
Clarify documentation of the Oracle connection-url string#11656hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
mosabua
reviewed
Mar 24, 2022
Member
There was a problem hiding this comment.
Reword to ensure misunderstanding .. you can NOT change the JDBC driver being used easily
Contributor
Author
There was a problem hiding this comment.
I'm conflicted on this. I see how this may imply that you can change drivers which is not advisable, but when navigating the Oracle docs for more information you probably need to know that we use the Thin driver.
hashhar
reviewed
Mar 26, 2022
hashhar
approved these changes
Mar 26, 2022
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Apr 25, 2022
Cherry-pick of trinodb/trino#9044 and Cherry-pick of trinodb/trino#11656 Co-authored-by: Joe Lodin <joe.lodin@starburstdata.com>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
Apr 25, 2022
Cherry-pick of trinodb/trino#9044 and Cherry-pick of trinodb/trino#11656 Co-authored-by: Joe Lodin <joe.lodin@starburstdata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current example URL used for the Oracle connector config is used to connect to a service name, which appears to be less common in practice than connecting to a single Oracle SID. Since the syntax is completely different between the two, it makes the most sense to use the more common example in our docs.
This also updates the outgoing Oracle docs link to use the most recent version of the Oracle docs, rather than version 11 which we don't even support.
Improvement
Documentation
Improve the Oracle connector documentation to be more useful to the average Oracle user.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: