Skip to content

Replace for instance with for example#11618

Merged
hashhar merged 1 commit intotrinodb:masterfrom
Jessie212:jt/for-instance-trino
Mar 25, 2022
Merged

Replace for instance with for example#11618
hashhar merged 1 commit intotrinodb:masterfrom
Jessie212:jt/for-instance-trino

Conversation

@Jessie212
Copy link
Copy Markdown
Contributor

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Changes were made in the documentation only.

How would you describe this change to a non-technical end user or system administrator?

Replace "for instance" with "for example" where appropriate.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2022
@Jessie212 Jessie212 requested a review from m57lyra March 22, 2022 17:42
@github-actions github-actions bot added the docs label Mar 22, 2022
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jessie212 Jessie212 requested a review from hashhar March 25, 2022 16:51
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see also one in Prometheus docs, a relatively small window. For instance:

Can you fix that up as well?

@Jessie212 Jessie212 force-pushed the jt/for-instance-trino branch from 213da8a to 1dfc17e Compare March 25, 2022 18:56
@Jessie212
Copy link
Copy Markdown
Contributor Author

I see also one in Prometheus docs, a relatively small window. For instance:

Can you fix that up as well?

Oops. That one slipped by me. Thanks!

@hashhar hashhar merged commit 5d4ad51 into trinodb:master Mar 25, 2022
@github-actions github-actions bot added this to the 375 milestone Mar 25, 2022
@Jessie212 Jessie212 deleted the jt/for-instance-trino branch March 25, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants