Skip to content

Return correct nullable value in information_schema.columns#11613

Merged
ebyhr merged 3 commits intotrinodb:masterfrom
ebyhr:ebi/information-schema-columns-nullable
Mar 24, 2022
Merged

Return correct nullable value in information_schema.columns#11613
ebyhr merged 3 commits intotrinodb:masterfrom
ebyhr:ebi/information-schema-columns-nullable

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 22, 2022

Description

Return correct nullable value in information_schema.columns
Fixes #6400

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# General
* Fix incorrect `is_nullable` value in `information_schema.columns` and `system.jdbc.columns` tables. ({issue}`11613`)

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2022
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ebyhr ebyhr force-pushed the ebi/information-schema-columns-nullable branch from f8b8047 to ef64c12 Compare March 23, 2022 00:22
@github-actions github-actions bot added the jdbc Relates to Trino JDBC driver label Mar 23, 2022
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 23, 2022

Fixing CI failure.

@ebyhr ebyhr force-pushed the ebi/information-schema-columns-nullable branch from ef64c12 to 2bd33b3 Compare March 23, 2022 07:15
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 23, 2022

(Pushed an empty commit as Hive PT wasn't triggered because of the label lack)

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 24, 2022

CI #11054

@ebyhr ebyhr merged commit 92e43cd into trinodb:master Mar 24, 2022
@ebyhr ebyhr deleted the ebi/information-schema-columns-nullable branch March 24, 2022 04:54
@ebyhr ebyhr mentioned this pull request Mar 24, 2022
@github-actions github-actions bot added this to the 375 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed jdbc Relates to Trino JDBC driver

Development

Successfully merging this pull request may close these issues.

Actual isNullable values not populated in system.jdbc.columns/hive.informationschema.columns/<jdbcdb>.informationschema.columns

3 participants