Skip to content

Support comments when building column definition in ClickHouse#11606

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-create-table-with-column-comment
Apr 5, 2022
Merged

Support comments when building column definition in ClickHouse#11606
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/clickhouse-create-table-with-column-comment

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 21, 2022

Description

Support comments when building column definition in ClickHouse

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# ClickHouse
* Add support for column comments when creating new tables. ({issue}`11606`)
* Add support for column comments when adding new columns. ({issue}`11606`)

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2022
@ebyhr ebyhr marked this pull request as draft March 28, 2022 02:35
@ebyhr ebyhr force-pushed the ebi/clickhouse-create-table-with-column-comment branch from af4de24 to 82e0b19 Compare April 5, 2022 00:00
@ebyhr ebyhr marked this pull request as ready for review April 5, 2022 05:30
@ebyhr ebyhr requested a review from hashhar April 5, 2022 05:32
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@ebyhr ebyhr merged commit 1de729d into trinodb:master Apr 5, 2022
@ebyhr ebyhr deleted the ebi/clickhouse-create-table-with-column-comment branch April 5, 2022 05:52
@ebyhr ebyhr mentioned this pull request Apr 5, 2022
@github-actions github-actions bot added this to the 376 milestone Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants