Skip to content

Use potentially redirected target table name in SHOW CREATE TABLE #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Mar 22, 2022
Merged

Use potentially redirected target table name in SHOW CREATE TABLE #11604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/sql/rewrite/ShowQueriesRewrite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ protected Node visitShowCreate(ShowCreate node, Void context)
List<Property> propertyNodes = buildProperties(targetTableName, Optional.empty(), INVALID_TABLE_PROPERTY, properties, allTableProperties);

CreateTable createTable = new CreateTable(
QualifiedName.of(objectName.getCatalogName(), objectName.getSchemaName(), objectName.getObjectName()),
QualifiedName.of(targetTableName.getCatalogName(), targetTableName.getSchemaName(), targetTableName.getObjectName()),
columns,
false,
propertyNodes,
Expand Down
2 changes: 1 addition & 1 deletion ...product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ public void testShowCreateTable()
createIcebergTable(icebergTableName, true);

assertThat(onTrino().executeQuery("SHOW CREATE TABLE " + hiveTableName))
.containsOnly(row("CREATE TABLE " + hiveTableName + " (\n" +
.containsOnly(row("CREATE TABLE " + icebergTableName + " (\n" +
" nationkey bigint,\n" +
" name varchar,\n" +
" regionkey bigint,\n" +
Expand Down