Skip to content

Add clean to mvn calls that can be retried#11593

Merged
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:ci-retry-clean
Mar 28, 2022
Merged

Add clean to mvn calls that can be retried#11593
electrum merged 1 commit intotrinodb:masterfrom
nineinchnick:ci-retry-clean

Conversation

@nineinchnick
Copy link
Copy Markdown
Member

@nineinchnick nineinchnick commented Mar 21, 2022

Description

If mvn crashes for any reason, it might leave behind invalid artifacts, and it'll keep failing in all subsequent runs. All these commands run on an already clean environment, but adding clean in the first run should not add too much overhead. Note that retries were added to handle failures during dependencies download and this will keep working the same.

Is this change a fix, improvement, new feature, refactoring, or other?
ci improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
ci

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2022
@nineinchnick nineinchnick requested a review from hashhar March 21, 2022 11:16
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

FYI @findepi .

@hashhar hashhar added maintenance Project maintenance task no-release-notes This pull request does not require release notes entry labels Mar 21, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Mar 21, 2022

If mvn crashes for any reason, it might leave behind invalid artifacts, and it'll keep failing in all subsequent runs.

can you please stitch this into commit message?

@findepi
Copy link
Copy Markdown
Member

findepi commented Mar 21, 2022

@nineinchnick btw is this addressing a problem that may occur, or a problem that has already manifested itself?

If mvn crashes for any reason, it might leave behind invalid artifacts,
and it'll keep failing in all subsequent runs.
@nineinchnick
Copy link
Copy Markdown
Member Author

nineinchnick commented Mar 21, 2022

@findepi I amended the commit message. I've seen this happening but I can't link to a GHA run. Maven failed with:

Warning: ][warning][gc,alloc] pool-717-thread-2: Retried waiting for GCLocker too often allocating 625002 words
Terminating due to java.lang.OutOfMemoryError: Java heap space

and then retries were failing with:

 Error:  Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on project trino-product-tests-launcher: Error creating shaded jar: error in opening zip file /home/runner/work/trino-lts/trino-lts/testing/trino-product-tests-launcher/target/trino-product-tests-launcher-370-SNAPSHOT.jar -> [Help 1]

@electrum electrum merged commit de0b797 into trinodb:master Mar 28, 2022
@github-actions github-actions bot added this to the 375 milestone Mar 28, 2022
@nineinchnick nineinchnick deleted the ci-retry-clean branch March 29, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants