Add clean to mvn calls that can be retried#11593
Merged
electrum merged 1 commit intotrinodb:masterfrom Mar 28, 2022
Merged
Conversation
hashhar
approved these changes
Mar 21, 2022
Member
can you please stitch this into commit message? |
Member
|
@nineinchnick btw is this addressing a problem that may occur, or a problem that has already manifested itself? |
If mvn crashes for any reason, it might leave behind invalid artifacts, and it'll keep failing in all subsequent runs.
d41975f to
6e1a88f
Compare
Member
Author
|
@findepi I amended the commit message. I've seen this happening but I can't link to a GHA run. Maven failed with: and then retries were failing with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
mvncrashes for any reason, it might leave behind invalid artifacts, and it'll keep failing in all subsequent runs. All these commands run on an already clean environment, but addingcleanin the first run should not add too much overhead. Note that retries were added to handle failures during dependencies download and this will keep working the same.Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: