Use session data provider in Oracle date mapping test#11586
Merged
ebyhr merged 6 commits intotrinodb:masterfrom Mar 29, 2022
Merged
Use session data provider in Oracle date mapping test#11586ebyhr merged 6 commits intotrinodb:masterfrom
ebyhr merged 6 commits intotrinodb:masterfrom
Conversation
3 tasks
Member
Author
|
cc @jirassimok |
tangjiangling
added
the
no-release-notes
tangjiangling
force-pushed
the
use-dataprovider-in-oracle-date-type-test
branch
from
94b4371 to
6139f3d
Compare
Member
Author
|
(Rebase to fix ci / maven-checks) |
hashhar
reviewed
Mar 21, 2022
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/AbstractTestOracleTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/AbstractTestOracleTypeMapping.java
Outdated
Show resolved
Hide resolved
Member
Author
|
ci / pt (default, suite-7-non-generic, 11) https://github.com/trinodb/trino/runs/5625648485?check_suite_focus=true |
tangjiangling
force-pushed
the
use-dataprovider-in-oracle-date-type-test
branch
from
6139f3d to
4d06197
Compare
Member
Author
|
Updated. (Rebased) |
- Use closeAfterClass in TestOracleTypeMapping - Rename getOracleSqlExecutor to onRemoteDatabase - Move trinoCreateAsSelect/trinoCreateAndInsert to before oracleCreateAndInsert
- Add missing test case for time/date/timestamp - Reorder time/date/timestamp test code to unify style
tangjiangling
force-pushed
the
use-dataprovider-in-oracle-date-type-test
branch
from
4d06197 to
4c99970
Compare
ebyhr
approved these changes
Mar 29, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement.
Just Oracle type mapping tests.
N/A.
Related issues, pull requests, and links
Related #11373
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: