Merged
Conversation
wendigo
requested review from
ebyhr and
findepi
and removed request for
findepi
wendigo
force-pushed
the
serafin/fix-dependency-scopes
branch
2 times, most recently
from
fea52ae to
30a81cc
Compare
findepi
reviewed
Mar 18, 2022
findepi
reviewed
Mar 18, 2022
findepi
reviewed
Mar 18, 2022
findepi
reviewed
Mar 18, 2022
Member
|
The scopes don't look correct to me, but it may be something i am missing. cc @electrum |
Contributor
Author
|
@findepi then I don't know why all the tests have passed with this change 🤷♂️ |
electrum
reviewed
Mar 20, 2022
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks for tracking these down.
wendigo
force-pushed
the
serafin/fix-dependency-scopes
branch
from
30a81cc to
fb62973
Compare
Contributor
Author
|
@electrum ptal |
wendigo
force-pushed
the
serafin/fix-dependency-scopes
branch
from
fb62973 to
a4efb58
Compare
hashhar
requested changes
Mar 25, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I have doubts about correctness. Or maybe i just misunderstand how dependencies work. I've left a single comment as example of what I'm seeing wrong but I'm sure there are other such changes too.
Contributor
Author
|
@electrum can you take a look? |
hashhar
approved these changes
Mar 31, 2022
wendigo
force-pushed
the
serafin/fix-dependency-scopes
branch
from
a4efb58 to
c206d55
Compare
Contributor
Author
|
@hashhar rebased to resolve conflicts, PTAL |
While testing maven-dependency-plugin update in airlift/airbase#304 it started reporting some dependencies as having invalid scope. These are now fixed and working both on the old and new plugin versions.
This version includes updated maven-dependency-plugin
wendigo
force-pushed
the
serafin/fix-dependency-scopes
branch
from
c206d55 to
f93de70
Compare
hashhar
approved these changes
Apr 4, 2022
hashhar
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing maven-dependency-plugin update in airlift/airbase#304
it started reporting some dependencies as having invalid scope. These are now fixed and working both
on the old and new plugin versions.