Extract adjustReplicatedJoinLocalExchangeCost and add TODO#11572
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Mar 21, 2022
Merged
Extract adjustReplicatedJoinLocalExchangeCost and add TODO#11572sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
force-pushed
the
ks/adjust_method
branch
from
38b0743 to
84bf0cc
Compare
losipiuk
reviewed
Mar 21, 2022
losipiuk
approved these changes
Mar 21, 2022
Extract adjustReplicatedJoinLocalExchangeCost so that it's easier to understand that local exchange cost for replicated joins has special treatment in cost calculators. Add TODO to remove adjustReplicatedJoinLocalExchangeCost once traits (e.g. data parallelism) are used to correctly estimate replicated join local exchange cost.
sopel39
force-pushed
the
ks/adjust_method
branch
from
84bf0cc to
b0f26c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract adjustReplicatedJoinLocalExchangeCost so that it's easier
to understand that local exchange cost for replicated joins
has special treatment in cost calculators.
Add TODO to remove adjustReplicatedJoinLocalExchangeCost
once traits (e.g. data parallelism) are used to correctly
estimate replicated join local exchange cost.