Skip to content

Support predicate pushdown on boolean column in MongoDB #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 18, 2022
Merged

Support predicate pushdown on boolean column in MongoDB #11556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,10 @@ private static Optional<Object> translateValue(Object trinoNativeValue, Type typ
requireNonNull(type, "type is null");
checkArgument(Primitives.wrap(type.getJavaType()).isInstance(trinoNativeValue), "%s (%s) is not a valid representation for %s", trinoNativeValue, trinoNativeValue.getClass(), type);

if (type == BOOLEAN) {
return Optional.of(trinoNativeValue);
}

if (type == TINYINT) {
return Optional.of((long) SignedBytes.checkedCast(((Long) trinoNativeValue)));
}
Expand Down
13 changes: 13 additions & 0 deletions plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,19 @@ public void testDropTable()
assertQueryFails("SELECT * FROM test.drop_table", ".*Table 'mongodb.test.drop_table' does not exist");
}

@Test
public void testBooleanPredicates()
{
assertUpdate("CREATE TABLE boolean_predicates(id integer, value boolean)");
assertUpdate("INSERT INTO boolean_predicates VALUES(1, true)", 1);
assertUpdate("INSERT INTO boolean_predicates VALUES(2, false)", 1);

assertQuery("SELECT id FROM boolean_predicates WHERE value = true", "VALUES 1");
assertQuery("SELECT id FROM boolean_predicates WHERE value = false", "VALUES 2");

assertUpdate("DROP TABLE boolean_predicates");
}

@Test
public void testNullPredicates()
{
Expand Down
12 changes: 12 additions & 0 deletions plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import static io.trino.spi.predicate.Range.lessThan;
import static io.trino.spi.predicate.Range.range;
import static io.trino.spi.type.BigintType.BIGINT;
import static io.trino.spi.type.BooleanType.BOOLEAN;
import static io.trino.spi.type.VarcharType.createUnboundedVarcharType;
import static java.util.Arrays.asList;
import static org.testng.Assert.assertEquals;
Expand All @@ -40,6 +41,7 @@ public class TestMongoSession
private static final MongoColumnHandle COL1 = new MongoColumnHandle("col1", BIGINT, false, Optional.empty());
private static final MongoColumnHandle COL2 = new MongoColumnHandle("col2", createUnboundedVarcharType(), false, Optional.empty());
private static final MongoColumnHandle COL3 = new MongoColumnHandle("col3", createUnboundedVarcharType(), false, Optional.empty());
private static final MongoColumnHandle COL4 = new MongoColumnHandle("col4", BOOLEAN, false, Optional.empty());

@Test
public void testBuildQuery()
Expand Down Expand Up @@ -105,4 +107,14 @@ public void testBuildQueryNull()
new Document(COL1.getName(), new Document("$eq", null))));
assertEquals(query, expected);
}

@Test
public void testBooleanPredicatePushdown()
{
TupleDomain<ColumnHandle> tupleDomain = TupleDomain.withColumnDomains(ImmutableMap.of(COL4, Domain.singleValue(BOOLEAN, true)));

Document query = MongoSession.buildQuery(tupleDomain);
Document expected = new Document().append(COL4.getName(), new Document("$eq", true));
assertEquals(query, expected);
}
}