Skip to content

Add logos to Trino connector pages#11552

Merged
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/logos-connectors
Apr 4, 2022
Merged

Add logos to Trino connector pages#11552
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/logos-connectors

Conversation

@Jessie212
Copy link
Contributor

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Add logos to Trino connector pages

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Mar 17, 2022
@Jessie212 Jessie212 requested a review from mosabua March 17, 2022 20:52
@github-actions github-actions bot added the docs label Mar 17, 2022
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and brings it all in line with Delta Lake ;-)

@Jessie212
Copy link
Contributor Author

Looks good and brings it all in line with Delta Lake ;-)

I agree.

@wendigo
Copy link
Contributor

wendigo commented Mar 19, 2022

@Jessie212 please squash those two commits into a single one.

@Jessie212 Jessie212 force-pushed the jt/logos-connectors branch from c94eff8 to 2ac8dd9 Compare March 21, 2022 16:25
@mosabua
Copy link
Member

mosabua commented Mar 23, 2022

Could you please merge @wendigo ?

@hashhar hashhar requested a review from martint March 23, 2022 06:29
@mosabua
Copy link
Member

mosabua commented Mar 25, 2022

@hashhar @ebyhr .. merge please?

@ebyhr
Copy link
Member

ebyhr commented Mar 26, 2022

@mosabua Let's wait confirmation from @martint

@mosabua
Copy link
Member

mosabua commented Apr 4, 2022

@martint can you please confirm and merge.

@martint martint merged commit 6972baa into trinodb:master Apr 4, 2022
@github-actions github-actions bot added this to the 376 milestone Apr 4, 2022
@Jessie212 Jessie212 deleted the jt/logos-connectors branch April 18, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants