Add Delta dynamic filtering tests#11549
Conversation
|
i renamed the PR, please rename the commit accordingly. |
e03a9a1 to
6e95c64
Compare
|
Can we add a test for delta lake that extends |
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We end up needing this and the large table on build side as we don't have a way to make delta lake split manager wait on DF (similar to dynamic-filtering.wait-timeout in hive and iceberg). It would be great to have that as it would simplify the testing and make it less prone to being flaky.
There was a problem hiding this comment.
Compared to Iceberg, DeltaLakeSplitSource produces the splits asynchronously. Does the dynamicFilteringWaitTimeoutMillis concept still apply in this case?
There was a problem hiding this comment.
Yes, HiveSplitSource produces splits asynchronously as well.
There was a problem hiding this comment.
Can we use searchScanFilterAndProjectOperatorStats from AbstractTestQueryFramework instead ?
There was a problem hiding this comment.
I tried now using searchScanFilterAndProjectOperatorStats. However, in case of dealing with the unfilteredStats it seems that there is no corresponding TableScanNode for the table lineitem.
There was a problem hiding this comment.
It's not working for the unfilteredStats case because searchScanFilterAndProjectOperatorStats always looks for a filter on top of the scan. We can keep the existing code here.
6e95c64 to
2ee1539
Compare
I will try adding such a test within this PR. |
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDynamicFiltering.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This can be parametrised as
@Test(timeOut = 60_000, dataProvider = "joinDistributionTypes")
@DataProvider
public Object[][] joinDistributionTypes()
{
return Stream.of(JoinDistributionType.values())
.collect(toDataProvider());
}
2ee1539 to
30d4ef4
Compare
Description
Test showcasing the dynamic filtering functionality in the Delta Lake connector
Test
Delta Lake connector test
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: