Remove regex usage from Identifier validation#11548
Merged
findepi merged 1 commit intotrinodb:masterfrom Mar 22, 2022
Merged
Conversation
Contributor
Author
|
|
Member
|
build isn't green |
wendigo
force-pushed
the
serafin/simplify-identifier-validation
branch
from
45099ae to
f27801f
Compare
Contributor
Author
|
@findepi checkstyle. Fixed, PTAL now |
findepi
reviewed
Mar 21, 2022
core/trino-parser/src/main/java/io/trino/sql/tree/Identifier.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Mar 21, 2022
Member
There was a problem hiding this comment.
nit: .substring is copying operation. can we do better?
findepi
reviewed
Mar 21, 2022
Member
There was a problem hiding this comment.
the "TAIL" name no longer applies
Contributor
Author
There was a problem hiding this comment.
As always, you are right :)
wendigo
force-pushed
the
serafin/simplify-identifier-validation
branch
from
bf3bad0 to
42a1dfc
Compare
This improves query planner performance.
findepi
force-pushed
the
serafin/simplify-identifier-validation
branch
from
42a1dfc to
aa49c82
Compare
Member
|
Added some rationale to cmt msg |
findepi
approved these changes
Mar 22, 2022
findepi
added
the
no-release-notes
Contributor
Author
|
Thx @findepi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JMH results: https://jmh.morethan.io/?gists=d2ceb76e826da7295d86efce0088a550,02f65f59e650539dad816fa36c8805f2
Improvement.
Core engine.
Worse -> better (tm @skrzypo987)
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: