Skip to content

Move iceberg maven configuration out of profiles#11540

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/remove-iceberg-maven-configuraiton-out-of-default-profile-ca5e1c
Mar 21, 2022
Merged

Move iceberg maven configuration out of profiles#11540
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/remove-iceberg-maven-configuraiton-out-of-default-profile-ca5e1c

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Mar 17, 2022

default profile is not active when other profile is activated, and
enforcer's and duplicate-finder's configuration should always apply.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Mar 17, 2022
@cla-bot cla-bot bot added the cla-signed label Mar 17, 2022
Copy link
Copy Markdown
Member

@jklamer jklamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will use when merged

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Mar 18, 2022

@hashhar @losipiuk PTAL
this is needed for #11468

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Mar 18, 2022

@hashhar @losipiuk PTAL this is needed for #11468

no longer needed. i merged that PR and will rebase this one instead.

`default` profile is not active when other profile is activated, and
enforcer's and duplicate-finder's configuration should always apply.
@findepi findepi force-pushed the findepi/remove-iceberg-maven-configuraiton-out-of-default-profile-ca5e1c branch from f879767 to 04cb9e6 Compare March 18, 2022 17:03
@findepi findepi changed the title Move iceberg maven configuraiton out of default profile Move iceberg maven configuration out of profiles Mar 18, 2022
@findepi findepi merged commit bdba04b into trinodb:master Mar 21, 2022
@findepi findepi deleted the findepi/remove-iceberg-maven-configuraiton-out-of-default-profile-ca5e1c branch March 21, 2022 09:36
@github-actions github-actions bot added this to the 375 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants