Skip to content

Improve singlestore timestamp precision mapping#11525

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
RameshByndoor:memsql_ts_fix
Mar 18, 2022
Merged

Improve singlestore timestamp precision mapping#11525
ebyhr merged 1 commit intotrinodb:masterfrom
RameshByndoor:memsql_ts_fix

Conversation

@RameshByndoor
Copy link
Copy Markdown
Member

@RameshByndoor RameshByndoor commented Mar 16, 2022

Improve singlestore timestamp precision mapping (#11524)

Description

Is this change a fix, improvement, new feature, refactoring, or other?
It's improvement, Avoids making an extra call to database while toColumnMapping is called

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Change in singlestore-connector, To get the exact precision of time, timestamp and datetime columns

How would you describe this change to a non-technical end user or system administrator?
This increases query performance and removes redundant calls to metadata tables.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@RameshByndoor RameshByndoor requested a review from ebyhr March 16, 2022 18:05
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm running all tests locally because PR from forked branch doesn't trigger SingleStore CI.
→ All tests passed

Screen Shot 2022-03-17 at 8 16 27

@RameshByndoor
Copy link
Copy Markdown
Member Author

Thanks for the review @ebyhr .

@ebyhr ebyhr merged commit b04cce1 into trinodb:master Mar 18, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 18, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 375 milestone Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants